[PATCH] D76290: [lit] Allow passing extra commands to executeShTest

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D76290#1930134 <https://reviews.llvm.org/D76290#1930134>, @yln wrote:

> I don't understand yet what this enables.  Please extend your commit message to elaborate a bit more for people (like me) who aren't familiar with libcxx testing.
>  Does this enable deriving new tests from existing source files or running existing tests (`.{pass,fail,sh}.cpp`) in a different way without needing to modify those dozens/hundreds of files?
>
> The change itself looks innocent enough and I don't want to block you on adding a test if there are currently none at all. LGTM.


I'm a little uncomfortable with declaring bankruptcy on the tests.  Doesn't the lit test suite itself use executeShTest?  Can we add a test there?

This would also be great to document if there's a place.  If there isn't, maybe we can change (maybe just one of) the libcxx tests to use this in the same commit, so that it's obvious in a blame what this is for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76290/new/

https://reviews.llvm.org/D76290