[PATCH] D76394: Cleanup the plumbing for DILineInfoSpecifier. [NFC]

[Sterling Augustine via Phabricator via llvm-commits]

saugustine created this revision.
Herald added subscribers: llvm-commits, rupprecht, MaskRay, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

1. FileLineInfoSpecifier::Default isn't the default for anything.

Rename to RawValue, which accurately reflects its role.

2. Most functions that take a part of a FileLineInfoSpecifier end up

constructing a full one later or plumb two values through. Make them
all just take a complete FileLineInfoSpecifier.

3. Printing basenames only was handled differently from all other

variants, make it parallel to all the other variants.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76394

Files:
  llvm/include/llvm/DebugInfo/DIContext.h
  llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
  llvm/include/llvm/DebugInfo/Symbolize/SymbolizableModule.h
  llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/lib/DebugInfo/Symbolize/DIPrinter.cpp
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76394.251203.patch
Type: text/x-patch
Size: 12208 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200318/dbeb1c11/attachment.bin>