[PATCH] D76375: [VPlan] Do not print mapping for Value2VPValue.

[Florian Hahn via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGfd2c15e6024f: [VPlan] Do not print mapping for Value2VPValue. (authored by fhahn).

Changed prior to commit:
  https://reviews.llvm.org/D76375?vs=251134&id=251187#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76375/new/

https://reviews.llvm.org/D76375

Files:
  llvm/lib/Transforms/Vectorize/VPlan.cpp
  llvm/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp


Index: llvm/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp
===================================================================
--- llvm/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp
+++ llvm/unittests/Transforms/Vectorize/VPlanHCFGTest.cpp
@@ -89,6 +89,9 @@
   EXPECT_EQ(IndvarAdd, ICmp->getOperand(0));
   EXPECT_EQ(VecBB->getCondBit(), ICmp);
 
+  // Add an external value to check we do not print the list of external values,
+  // as this is not required with the new printing.
+  Plan->addVPValue(&*F->arg_begin());
   std::string FullDump;
   raw_string_ostream(FullDump) << *Plan;
   EXPECT_EQ(R"(digraph VPlan {
Index: llvm/lib/Transforms/Vectorize/VPlan.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/VPlan.cpp
+++ llvm/lib/Transforms/Vectorize/VPlan.cpp
@@ -580,19 +580,10 @@
   OS << "graph [labelloc=t, fontsize=30; label=\"Vectorization Plan";
   if (!Plan.getName().empty())
     OS << "\\n" << DOT::EscapeString(Plan.getName());
-  if (!Plan.Value2VPValue.empty() || Plan.BackedgeTakenCount) {
-    OS << ", where:";
-    if (Plan.BackedgeTakenCount) {
-      OS << "\\n";
-      Plan.BackedgeTakenCount->print(OS, SlotTracker);
-      OS << " := BackedgeTakenCount";
-    }
-    for (auto Entry : Plan.Value2VPValue) {
-      OS << "\\n";
-      Entry.second->print(OS, SlotTracker);
-      OS << DOT::EscapeString(" := ");
-      Entry.first->printAsOperand(OS, false);
-    }
+  if (Plan.BackedgeTakenCount) {
+    OS << ", where:\\n";
+    Plan.BackedgeTakenCount->print(OS, SlotTracker);
+    OS << " := BackedgeTakenCount";
   }
   OS << "\"]\n";
   OS << "node [shape=rect, fontname=Courier, fontsize=30]\n";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76375.251187.patch
Type: text/x-patch
Size: 1695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200318/0f45a1a1/attachment.bin>