[PATCH] D75672: [ValueTypes] Add support for scalable EVTs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 13:02:03 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: llvm/include/llvm/CodeGen/ValueTypes.h:257
     EVT getVectorElementType() const {
-      assert(isVector() && "Invalid vector type!");
+      assert((isVector() || isScalableVector()) && "Invalid vector type!");
       if (isSimple())
----------------
`isVector() || isScalableVector()` is the same thing as `isVector()`, I think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75672/new/

https://reviews.llvm.org/D75672





More information about the llvm-commits mailing list