[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 18 09:16:16 PDT 2020
reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.
It's not clear what bug you think you're fixing. Please provide a description of the bad behaviour.
================
Comment at: llvm/test/MC/X86/align-branch-64-basic.s:106
- # CHECK: <test_pad_via_relax>:
- # CHECK: 200: testq
----------------
Please restore this test and show any diff. This test is not an unimplemented case, it's testing the jne being relaxed which is happening.
================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:10
+ # We should not increase the length of this jmp to reduce the bytes of
+ # following nops, doing so would make the jmp misaligned.
+# CHECK: 18: jmp
----------------
This case should already be handled by skipping instructions past the branch align.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76285/new/
https://reviews.llvm.org/D76285
More information about the llvm-commits
mailing list