[PATCH] D76357: [AMDGPU] Implement wave32 DWARF register mapping

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu marked 11 inline comments as done.
RamNalamothu added inline comments.


================
Comment at: llvm/unittests/MC/AMDGPU/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS
+  ${LLVM_TARGETS_TO_BUILD}
----------------
arsenm wrote:
> Missing the file with check for AMDGPU registered target? I'm not sure exactly how that works with unit tests, but it's done for GlobalISel unit tests with AArch64
Sorry didn't get you and also I didn't notice anything special here with AArch64 unit tests.


================
Comment at: llvm/unittests/MC/AMDGPU/DwarfRegMappings.cpp:30
+
+  const char *Triple = "amdgcn";
+  std::string Error;
----------------
arsenm wrote:
> Can this be a StringRef? You also don't reuse it below. This should probably also use the full 3 component triple
Using only the 2 component triple as the dwarf register mappings are agnostic to a particular OS (the 3rd component).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76357/new/

https://reviews.llvm.org/D76357