[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 09:14:30 PDT 2020


aprantl added a comment.

I think this is starting to look good now. I found two more opportunities for improving the output... sorry about finding these piecemeal.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/macho_archive_section_sizes.test:6
+CHECK-NEXT:----------------------------------------------------
+CHECK-NEXT:SECTION         SIZE
+CHECK-NEXT:--------------  ----
----------------
What's the unit of SIZE? Should we print that?


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/macho_archive_section_sizes.test:24
+CHECK-NEXT:__debug_info    56   (4.00%)
+CHECK-NEXT:__debug_loc     0    (0.00%)
+CHECK-NEXT:__debug_ranges  0    (0.00%)
----------------
Should we right-align all the numbers?

```
56
 0
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205





More information about the llvm-commits mailing list