[PATCH] D76303: [Pipeliner] Fix the bug in pragma that disables the pipeliner

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 04:51:32 PDT 2020


avl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:314
+    // Reset the pragma for the next loop in iteration.
+    disabledByPragma = false;
     return false;
----------------
it looks like more appropriate place to set to default state would be in start of  setPragmaPipelineOptions:


```
void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) {
  disabledByPragma = false;
```

Additionally, II_setByPragma could also be set to default state here. though this is for separate patch.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76303/new/

https://reviews.llvm.org/D76303





More information about the llvm-commits mailing list