[PATCH] D76265: [PowerPC] add IR level isFMAFasterThanFMulAndFAdd - NFC

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15304
                                                    EVT VT) const {
   VT = VT.getScalarType();
 
----------------
steven.zhang wrote:
> Don't get the scalar type as the parameter of "Ty" in IR version is the type of the function.
I think You mean in IR version, I already call `getScalarType()` , so no need to call it again?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15306
 
   if (!VT.isSimple())
     return false;
----------------
steven.zhang wrote:
> You don't need this check any more as you don't call the getSimpleVT now.
Right.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76265/new/

https://reviews.llvm.org/D76265