[PATCH] D75837: Introduce std.execute_region op

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In D75837#1927525 <https://reviews.llvm.org/D75837#1927525>, @silvas wrote:

> > +1 This is also exactly what I wanted to say. If there were arguments in the land you were starting from (say you were inlining a call), those arguments should just get propagated and eliminated. Keeping arguments around will necessitate all kinds of tracking/bookkeeping in moving code across, reimplementing existing canonicalizations on this op and largely defeating the purpose of this op - which is to let SSA dominance and dataflow work freely from above and through it.
>
> Since river is working on making dataflow be able to transparently look through non-explicit captures for ops like this, how important is it to not have explicit args?
>
> That is, we can canonicalize the args away, but having the args shouldn't hurt?


I missed this, do you have a pointer?
I assume this wouldn't be zero cost / transparent though.

> 1. The cost of pushing all clients of this op to establish the canonical form of no explicit captures mandatorily upon creation

I may be missing something, but isn't it just a direct RAUW? What is the cost herE?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837