[PATCH] D39111: Extensible LLVM RTTI

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 22:08:51 PDT 2020


dblaikie added a comment.

In D39111#1925642 <https://reviews.llvm.org/D39111#1925642>, @lhames wrote:

> @dblaikie, @chandlerc -- Any further thoughts on this one?


I'd like Chandler to come back around on this, given the reservations he expressed, but not sure he'll get to it - so might have to just figure it out ourselves. I share some of those reservations (that'd be easy to misuse this & have code that doesn't work on Windows - people won't read the documentation & might write the broken template situation), but maybe less concerned than Chandler was.

> I'd like to get this in as we have some use cases in the JIT (e.g. querying and down casting to user defined MaterializationUnit types when dispatching JIT work). At the time these were future use cases, now they're current ones. :)

Could you sketch up a user/use case to demonstrate the use (maybe a Kaleidoscope example?)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39111/new/

https://reviews.llvm.org/D39111





More information about the llvm-commits mailing list