[PATCH] D74128: AMDGPU/GlobalISel: Fully handle 0 dmask case during legalize

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 21:36:26 PDT 2020


vitalybuka added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3190
+      B.buildUndef(MI.getOperand(0));
+      MI.eraseFromParent();
+      return true;
----------------
I guess eraseFromParent conflicts with
```
auto ChangedInstr = make_scope_exit([&] { Observer.changedInstr(MI); });
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74128/new/

https://reviews.llvm.org/D74128





More information about the llvm-commits mailing list