[PATCH] D75580: [llvm][CodeGen][SVE] Implement IR intrinsics for gather prefetch.

Tue Mar 17 19:28:02 PDT 2020

fpetrogalli added a subscriber: vitalybuka.
fpetrogalli added a comment.

In D75580#1925234 <https://reviews.llvm.org/D75580#1925234>, @nickdesaulniers wrote:

> Hello! Thanks for this patch.  In release builds, I'm seeing lots of warnings that:
>
>   In file included from ../lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:9:
>   ../lib/Target/AArch64/MCTargetDesc/AArch64AddressingModes.h:850:13: warning: unused function 'isValidImmForSVEVecImmAddrMode' [-Wunused-function]
>   static bool isValidImmForSVEVecImmAddrMode(unsigned OffsetInBytes,
>               ^
>
>
> Also, there's one instance:
>
>   ../lib/Target/AArch64/AArch64ISelLowering.cpp:12714:21: warning: unused variable 'OffsetConst' [-Wunused-variable]
>       ConstantSDNode *OffsetConst = dyn_cast<ConstantSDNode>(Offset.getNode());
>                       ^
>
>
> Can you please take a look?

Hi @nickdesaulniers ,

thank you for pointing this out! Someone has been faster than me in reacting to this! https://github.com/llvm/llvm-project/commit/f20dcc31e31fdb94159572af1e2a87dcc5d02bd8 (@vitalybuka - thank you for your patch)

Please let me know if you see any other problems with the patch.

Kind regards,

Francesco

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75580/new/

https://reviews.llvm.org/D75580