[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

In D76252#1927200 <https://reviews.llvm.org/D76252#1927200>, @MaskRay wrote:

> In D76252#1926984 <https://reviews.llvm.org/D76252#1926984>, @int3 wrote:
>
> > The `no-id-dylink.s` test needs yaml2obj to generate an invalid dylib, but yeah I can replace the other two with binary blobs
>
>
> We are trying to avoid binary blob in LLVM binary utilities + lld. @grimar has done lots of work in this area. Can you figure out how much effort it takes to implement relevant features in yaml2obj Mach-O? I hope we can avoid binary blobs early.


Yeah but my point is that we are not going to keep using yaml2obj for most test cases. Once lld is able to produce binary files used in the tests, we can replace the binary blobs with an invocation of lld. So checking in binary files as a temporary measure is pretty much okay to me, and it actually look like a good engineering decision to me. At this early stage of development, I think things don't always have to be done in the "right" way, as it usually has lots of scaffolding which will be replaced or removed later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252