[PATCH] D76329: [MLIR] Deduplicate dialect registration by ClassID

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 18:23:35 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added a comment.

LGTM, but I'd like to hear from River as well.

I am not sure what you mean with:

> This potentially introduces some issues if callers using non-standard dialect registration functions passed to registerDialectAllocator and they are silently overridden.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76329/new/

https://reviews.llvm.org/D76329





More information about the llvm-commits mailing list