[PATCH] D76288: [lit] Add builtin support for flaky tests in lit

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 15:08:07 PDT 2020


yln accepted this revision.
yln added a comment.

This looks like a reasonable way to enable per-test retries.  (I feel that `test_retry_attempts` was tacked on as an afterthought.)
Thanks for adding tests, and also thanks to Reid for giving good feedback.

LGTM, with one quick ask to add 2 more tests to document the behavior/intereaction with `config.test_retry_attempts`:

- `test_retry_attempts` (without `ALLOW_RETRIES`) should still be respected (this test should have been there in the first place).
- `ALLOW_RETRIES` overwrites `test_retry_attempts`, when both are specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76288/new/

https://reviews.llvm.org/D76288





More information about the llvm-commits mailing list