[PATCH] D76292: [ARM] Change VDUP type to i32 for MVE

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 10:44:09 PDT 2020


efriedma added a comment.

I haven't been following the MVE work that closely, but changing the operand type of MVE vdup makes sense.  My one concern here is the potential for confusion due to the opcode; VDUP for NEON and MVE have the same opcode and result type, but the operand types are different.  Doesn't really matter much for isel patterns, but could be confusing for writing target-specific combines.

Yes, PerformVMOVhrCombine could be improved to handle more cases, independent of what happens here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76292/new/

https://reviews.llvm.org/D76292





More information about the llvm-commits mailing list