[PATCH] D76288: [lit] Add builtin support for flaky tests in lit

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 10:10:58 PDT 2020


ldionne added a comment.

In D76288#1926868 <https://reviews.llvm.org/D76288#1926868>, @rnk wrote:

> In D76288#1926688 <https://reviews.llvm.org/D76288#1926688>, @ldionne wrote:
>
> >
>
>
> [...]
>
> I don't think we need to put any effort into making this work. Flaky failing tests should be disabled instead.
>
> Basically, looks good, but I'd suggest a different tag. Thanks!


Great, thanks! I'll change the keyword. Two questions:

1. Is this set of reviewers fine for lit? I'm not familiar with that component.
2. Is there documentation for the ShTest format? I could add something to https://llvm.org/docs/TestingGuide.html, or maybe we're better off keeping this feature on the down low?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76288/new/

https://reviews.llvm.org/D76288





More information about the llvm-commits mailing list