[PATCH] D76263: AMDGPU: Initial, crude support for indirect calls

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 09:06:55 PDT 2020


sameerds accepted this revision.
sameerds added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/indirect-call.ll:198
+
+; define void @test_indirect_call_vgpr_ptr_arg(void(i32)* %fptr) {
+;   call void %fptr(i32 123)
----------------
sameerds wrote:
> Should have one more test where the parameter passed to the callee is not an immediate.
I suppose there is nothing special about the parameter handling for this change. So I'll leave it to @arsenm to decide if such a test is necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76263/new/

https://reviews.llvm.org/D76263





More information about the llvm-commits mailing list