[PATCH] D75131: [XCOFF][AIX] Enable -r option for llvm-objdump

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 08:31:32 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:24
+  if (SymI == Obj->symbol_end())
+    return make_error<GenericBinaryError>("Could not get relocation symbol.",
+                                          object_error::parse_failed);
----------------
hubert.reinterpretcast wrote:
> jhenderson wrote:
> > Errors usually have lower case first letter and no trailing full stop.
> Thanks for pointing this out. We will correct this.
Suggestion:
"invalid symbol reference in relocation entry"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131





More information about the llvm-commits mailing list