[PATCH] D75863: [AIX] Implement by-val caller arguments in a single register

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7163
+      SDValue RegVal;
+      for (unsigned Bytes = 0; Bytes != ByValSize;) {
+        unsigned N = PowerOf2Floor(ByValSize - Bytes);
----------------
I'm curious as to what happens with 0 sized parameter, will they need special handling like they do on the callee side or do they need to be skipped? 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:1
+%struct.S1 = type { [1 x i8] }
+ at gS1 = external global %struct.S1, align 1
----------------
Caught by the automatic testing bots, this test doesn't have a RUN step. 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:197
+; ASM64PWR4-NEXT:  addi 1, 1, 112
+>>>>>>> 647d1a89a551... Implement byval arguments in single register
----------------
looks like a git artifact here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75863/new/

https://reviews.llvm.org/D75863