[PATCH] D75023: [WIP][RISCV][GlobalISel] Add lowerCall for calling convention

Joseph Faulls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 05:07:07 PDT 2020


Joe added a comment.

If you're supporting a pointer value return type, should there be a test for this?

Other than that, this looks fine to me - although should wait until somebody more experienced looks at it.

Side note: Would it be worth, in the future, to outline the process of finding In/OutputArgs and ArgInfos to something like a computeOutgoingArgs/computeIncomingArgs that fills a list of ISD::In/OutputArg and ArgInfos? Or would this just obfuscate things?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75023/new/

https://reviews.llvm.org/D75023





More information about the llvm-commits mailing list