[PATCH] D76240: [Sanitizers][Test] If the default linker is LLD, disable threads

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 04:27:48 PDT 2020


nemanjai added a comment.

In D76240#1925275 <https://reviews.llvm.org/D76240#1925275>, @cryptoad wrote:

> Shouldn't `-DLLVM_PARALLEL_LINK_JOBS=1` be used to avoid the described condition?


Nope. The issue is not that the build fails because of excessive parallelism when doing a wide build. The issue is when running `ninja check-all` (i.e. the lit tests). The default for lit is to run as many test cases at a time as there are virtual cpu's on the system. This is good because it gets through the very lightweight lit tests very quickly. And if the comment from `Parallel.h` I mentioned above is the number of threads `lld` will use, each instance of `lld` will spawn up to 1024 threads.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76240/new/

https://reviews.llvm.org/D76240





More information about the llvm-commits mailing list