[PATCH] D73447: AMDGPU/GlobalISel: Legalize non-a16 non-NSA images

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Thank you, this looks good to me modulo one question.



================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:2269-2285
+// This is equivalent to the G_INTRINSIC*, but the operands may have
+// been legalized depending on the subtarget requirements.
+def G_AMDGPU_INTRIN_IMAGE_LOAD : AMDGPUGenericInstruction {
+  let OutOperandList = (outs type0:$dst);
+  let InOperandList = (ins unknown:$intrin, variable_ops);
+  let hasSideEffects = 0;
+  let mayLoad = 1;
----------------
What about atomics? They should be mayLoad = mayStore = 1, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73447/new/

https://reviews.llvm.org/D73447