[PATCH] D76213: [llvm-nm] Add test for `--debug-syms --dynamic`

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/debug-syms.test:35
+# RUN: yaml2obj --docnum=2 %s -o %t2.o
+# RUN: llvm-nm --debug-syms --dynamic %t2.o | FileCheck %s --implicit-check-not U --check-prefix DYNSYM
+# RUN: llvm-nm -a --dynamic %t2.o | FileCheck %s --implicit-check-not U --check-prefix DYNSYM
----------------
jhenderson wrote:
> grimar wrote:
> > I am not an expert in `llvm-nm`, but is `debug-syms.test` is a right place for this test?
> > I'd expect to see a test case for `--dynamic/-D`, but I've not found.
> > Seems we want to add one instead?
> I would suggest that a --dynamic dedicated test file makes sense, but that this test case here in this file also makes sense.
> I would suggest that a --dynamic dedicated test file makes sense, but that this test case here in this file also makes sense.
Yeah, I've also came to it. Though we probably should not test `-D` here s it probably enough to test it once in a " --dynamic dedicated test file"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76213/new/

https://reviews.llvm.org/D76213