[PATCH] D76227: [obj2yaml] - SHT_DYNAMIC and SHT_REL* sections: stop dumping sh_entsize field when it has the default value.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Looks good to me. I think it would be expected that an unspecified EntSize means "the default" for a section.

I assume there are test cases that show that we do dump it when it is not the default for these kinds of sections?



================
Comment at: llvm/test/tools/obj2yaml/dynamic-section.test:4-7
 ## Check we can use obj2yaml to yamalize the object containing
 ## .dynamic section. Check that resulting section has the
-## proper attributes and dynamic tags.
+## proper attributes and dynamic tags and that we do not dump
+## the default sh_entsize.
----------------
If you reflow this comment, you should be able to fit it onto 3 lines, I think.


================
Comment at: llvm/test/tools/obj2yaml/relr-section.yaml:4
 ## Test we use the "Entries" property when it is possible do
-## dump values correctly.
+## dump values correctly. Check we do not dump sh_entsize when
+## it has the default value.
----------------
Also, check we do not...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76227/new/

https://reviews.llvm.org/D76227