[PATCH] D75527: [yaml2obj] - Add `ELFYAML::YAMLIntUInt` to fix how we parse a relocation `Addend` key.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 01:34:38 PDT 2020


grimar marked an inline comment as done.
grimar added a comment.

@jhenderson, does this version LGTY?



================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:996
+  // We do not accept negative hex numbers for simplicity
+  // because perhaps nobody might want to them.
+  if (Scalar.empty() || Scalar.startswith("-0x"))
----------------
I'll change this to "might want to use them".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75527/new/

https://reviews.llvm.org/D75527





More information about the llvm-commits mailing list