[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

Tue Mar 17 00:52:15 PDT 2020

ruiu added a comment.

As to the tests, we generally don't use yaml2obj to write tests (except for COFF which is historically using yaml2obj). If you are using yaml2obj just until lld itself is able to produce files used by tests, I don't think you have to spend too much time writing tests in yaml2obj. Instead, you can submit binary files for now and then replace them later.

================
Comment at: lld/MachO/Target.h:18
 enum {
+  WordSize = 8,
   PageSize = 4096,
----------------
int3 wrote:
> ruiu wrote:
> > Are you going to make it work only for 64-bit platforms? IIRC, both macOS and iOS are dropping 32-bit app support, so it is probably a good choice to not support 32-bit, but just to confirm.
> I'm not sure we're 100% not going to support it, but we're definitely prioritizing 64-bit for now
Then please leave a comment here saying that we are currently supporting only 64-bit targets as macOS and iOS are deprecating 32-bit apps.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252