[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 06:26:24 PDT 2020


ostannard added a comment.

I forgot to restrict the new tests to only run when the relevant disassembler is built, should be fixed by rG161f70eae6cd <https://reviews.llvm.org/rG161f70eae6cda06169401045b666f3ff7a4ee023> and rG2878c6693875 <https://reviews.llvm.org/rG2878c6693875f841f297bf347963ce26841f9c0a>.

The tests are also failing on some windows bots with unicode errors, so I've disabled them on windows with rGf4cb9c919e28 <https://reviews.llvm.org/rGf4cb9c919e28276222873453cf85de9e5a3c7be5>. These tests were passing locally in a Windows 10 VM, I'm not sure what is different about the buildbots.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720





More information about the llvm-commits mailing list