[PATCH] D76158: Add inline assembly load hardening mitigation for Load Value Injection (LVI) on X86 [6/6]
Scott Constable via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 16 13:07:59 PDT 2020
sconstab marked an inline comment as done.
sconstab added inline comments.
================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3156
+
+ if (getSTI().getFeatureBits()[X86::FeatureLVILoadHardening]) {
+ auto Flags = Inst.getFlags();
----------------
craig.topper wrote:
> Can we move this code out to a separate method called from here? Something like performLVIMitigation?
I created two new methods. Let me know what you think.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76158/new/
https://reviews.llvm.org/D76158
More information about the llvm-commits
mailing list