[PATCH] D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

In D76146#1922222 <https://reviews.llvm.org/D76146#1922222>, @aprantl wrote:

> Mechanically LGTM to me. I'm not sure if this shouldn't be done in DwarfExpression instead.


So that we basically insert a `DW_OP_convert 0x0` after each chain of `DW_OP_convert` operations in the input DIExpression? That sounds reasonable, and it should have a lot smaller impact on the code. I wonder though if it would be limiting to only have the DwarfExpression world type ware if/when we later want on to support more base type-based operations (e.g. DW_OP_const_type), but perhaps not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76146/new/

https://reviews.llvm.org/D76146