[PATCH] D75695: [StackProtector] Catch direct out-of-bounds when checking address-takenness

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:01:29 PDT 2020


efriedma accepted this revision.
efriedma added a comment.

I don't think we're really getting much benefit out of testing this on multiple targets; as long as we have coverage for 32-bit and 64-bit targets, none of the relevant logic is actually target-specific. So I'd just get rid of the ARM/AArch64 tests, I think, since x86 conveniently has 32-bit and 64-bit targets.

Otherwise LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75695/new/

https://reviews.llvm.org/D75695





More information about the llvm-commits mailing list