[PATCH] D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed.

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:01:28 PDT 2020


jpienaar added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:996
+  LLVM_DEBUG({
+    Diagnostic diag(op->getLoc(), DiagnosticSeverity::Error);
+    reasonCallback(diag);
----------------
Is a match failing really an error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76203/new/

https://reviews.llvm.org/D76203





More information about the llvm-commits mailing list