[PATCH] D76129: Fix possible assertion when using PBQP with debug info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/csw-debug-assert.ll:109
+!45 = !DILocation(line: 8, column: 23, scope: !38)
+!46 = !DILocation(line: 8, column: 21, scope: !38)
+!47 = !DILocation(line: 8, column: 11, scope: !38)
----------------
danilaml wrote:
> aprantl wrote:
> > You can probably significantly shorten the test by manually assigning all instructions the same !dbg location.
> I've simplified the test. Do you think manual dbg hacking is still necessary?
Getting the tests as minimal as possible helps in the long term with maintenance. All tests need to updated occasionally for various IR changes and then it really helps to know what is relevant to the test and what isn't. So, I would do it, since it's not a lot of work and helps focus on what's important.


================
Comment at: llvm/test/CodeGen/Generic/csw-debug-assert.ll:76
+!29 = !{!"omnipotent char", !30, i64 0}
+!30 = !{!"Simple C/C++ TBAA"}
+!31 = !DILocation(line: 6, column: 30, scope: !21)
----------------
Do you need the TBAAA info?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76129/new/

https://reviews.llvm.org/D76129