[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp:780
+  if (pf->hasName())
+    personality = b.getSymbolRefAttr(pf->getName());
+  // If it doesn't have a name, currently, only function pointers that are
----------------
Can we change these to early return instead?

if (...)
  return b...;

if (auto ce ...) {

}
return FlatSymbolRefAttr();


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888