[PATCH] D75992: [DEXTER] Add step.UNKNOWN check to DexTer for None valued steps.

Tom Weaver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 09:49:45 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG09f4bdc03f89: [DexTer] Add step.UNKNOWN check for NoneType line numbers. (authored by TWeaver).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75992/new/

https://reviews.llvm.org/D75992

Files:
  debuginfo-tests/dexter/dex/dextIR/DextIR.py


Index: debuginfo-tests/dexter/dex/dextIR/DextIR.py
===================================================================
--- debuginfo-tests/dexter/dex/dextIR/DextIR.py
+++ debuginfo-tests/dexter/dex/dextIR/DextIR.py
@@ -102,6 +102,10 @@
             frame_step = self._get_prev_step_in_this_frame(step)
             prev_step = frame_step if frame_step is not None else prev_step
 
+        # If we're missing line numbers to compare then the step kind has to be UNKNOWN.
+        if prev_step.current_location.lineno is None or step.current_location.lineno is None:
+            return StepKind.UNKNOWN
+
         # We're in the same func as prev step, check lineo.
         if prev_step.current_location.lineno > step.current_location.lineno:
             return StepKind.VERTICAL_BACKWARD


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75992.250586.patch
Type: text/x-patch
Size: 791 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/d5662389/attachment.bin>


More information about the llvm-commits mailing list