[PATCH] D76195: [llvm-readobj][test] - Remove unused Offset key from reloc-types-*.test tests

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

In D76195#1924441 <https://reviews.llvm.org/D76195#1924441>, @jhenderson wrote:

> LGTM, but please wait for @MaskRay.


Quote http://www.sco.com/developers/gabi/latest/ch4.reloc.html

> If multiple consecutive relocation records are applied to the same relocation location (r_offset), they are composed instead of being applied independently, as described above. By consecutive, we mean that the relocation records are contiguous within a single relocation section. By composed, we mean that the standard application described above is modified as follows:
> 
> - In all but the last relocation operation of a composed sequence, the result of the relocation expression is retained, rather than having part extracted and placed in the relocated field. The result is retained at full pointer precision of the applicable ABI processor supplement.
> - In all but the first relocation operation of a composed sequence, the addend used is the retained result of the previous relocation operation, rather than that implied by the relocation type.

"the addend used is the retained result of the previous relocation operation" This is what I meant by "more invalid".

Though, I think it is ok because llvm-readobj does not modify file contents.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76195/new/

https://reviews.llvm.org/D76195