[PATCH] D76226: [yaml2obj][test] - Ensure that dynamic section has sh_entsize correctly set.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 05:52:27 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added a subscriber: emaste.
Herald added a reviewer: espindola.

This updates the existent test because it lacks coverage.


https://reviews.llvm.org/D76226

Files:
  llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml


Index: llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
===================================================================
--- llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
+++ llvm/test/tools/yaml2obj/ELF/dynamic-section.yaml
@@ -1,18 +1,29 @@
 ## Ensures that dynamic section has sh_entsize correctly set.
 
-# RUN: yaml2obj %s -o %t
-# RUN: llvm-readobj --sections %t | FileCheck %s --check-prefix=SECTION
+# RUN: yaml2obj -DBITS=64 %s -o %t.64
+# RUN: llvm-readobj --sections %t.64 | FileCheck %s -DENTSIZE=16
+# RUN: yaml2obj -DBITS=32 %s -o %t.32
+# RUN: llvm-readobj --sections %t.32 | FileCheck %s -DENTSIZE=8
 
 !ELF
 FileHeader:
-  Class:           ELFCLASS64
-  Data:            ELFDATA2LSB
-  Type:            ET_DYN
-  Machine:         EM_X86_64
+  Class:   ELFCLASS[[BITS]]
+  Data:    ELFDATA2LSB
+  Type:    ET_DYN
+  Machine: EM_X86_64
 Sections:
-  - Name: .dynamic
-    Type: SHT_DYNAMIC
+## Test default values set by yaml2obj.
+  - Name:  .dynamic
+    Type:  SHT_DYNAMIC
     Flags: [ SHF_ALLOC, SHF_WRITE ]
+## Test we can use an arbitrary value for sh_entsize.
+  - Name:    .mydynamic
+    Type:    SHT_DYNAMIC
+    EntSize: 0xFE
 
-# SECTION: Name: .dynamic
-# SECTION: EntrySize: 16
+# CHECK:      Name:      .dynamic
+# CHECK:      EntrySize:
+# CHECK-SAME:           {{^}} [[ENTSIZE]]{{$}}
+# CHECK:      Name:      .mydynamic
+# CHECK:      EntrySize:
+# CHECK-SAME:           {{^}} 254{{$}}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76226.250540.patch
Type: text/x-patch
Size: 1428 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/41d17fcd/attachment.bin>


More information about the llvm-commits mailing list