[PATCH] D76213: [llvm-nm] Add test for `--debug-syms --dynamic`

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 05:17:14 PDT 2020


Higuoxing marked an inline comment as done.
Higuoxing added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/debug-syms.test:56
+    Binding: STB_LOCAL
+    Section: .data
+
----------------
grimar wrote:
> Is it important to have "Section"?
> 
> 
> Is it important to have "Section"?

I think it's important. We use `--implicit-check-not U` to detect NULL symbol, so we should specify section field for symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76213/new/

https://reviews.llvm.org/D76213





More information about the llvm-commits mailing list