[PATCH] D76200: [VPlan] Use underlying value for printing, if available.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:588
     }
     for (auto Entry : Plan.Value2VPValue) {
       OS << "\\n";
----------------
Ayal wrote:
> If now every VPValue that wraps a Value clearly says so in its name, does it hopefully make this "%vpA := %irX" part of "where:" redundant?
I can drop that in a follow-up, if that's ok?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:818
+  const Value *UV = getUnderlyingValue();
+  if (UV && UV->hasName()) {
+    OS << "%vp." << UV->getName();
----------------
Ayal wrote:
> Even if UV does not have a name, could we still indicate that VPValue wraps it; possibly by calling UV->printAsOperand()?
Done! It required to add special handling for constants and also a bit of code to drop the % printed by printAsOperand, but now all underlying IR values should be printed consistently. A full list of the required changes can be found in the update comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76200/new/

https://reviews.llvm.org/D76200