[PATCH] D76176: [X86] Disable nop padding before instruction following hardcode

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 15 20:57:04 PDT 2020


skan marked an inline comment as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:495
+    return DF != PrevInstPosition.first ||
+           DF->getContents().size() != PrevInstPosition.second;
+
----------------
LuoYuanke wrote:
> Does hard coded instruction occupy one separate fragment? Need comments to explain how to check hard code. Better to have a diagram.
Hard coded instruction may occupy one separate fragment. It's not a good way to enumerate all the cases  but I will add more comments here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76176/new/

https://reviews.llvm.org/D76176





More information about the llvm-commits mailing list