[PATCH] D75664: [Coroutines] Also check lifetime intrinsic for local variable when build coroutine frame

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 15 18:15:11 PDT 2020


junparser marked an inline comment as done.
junparser added a comment.

@modocache Thanks !



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1470
+            break;
+        }
+      else
----------------
modocache wrote:
> Nit-pick: I think the LLVM coding style would have you remove these `for` loop braces. There's only a single statement in the `for` loop, the `if` statement above, so you technically don't need these here.
Thanks, I'll update this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75664/new/

https://reviews.llvm.org/D75664





More information about the llvm-commits mailing list