[PATCH] D76202: [mlir] Remove the PatternState class and simplify PatternMatchResult.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 15 14:27:39 PDT 2020


rriddle created this revision.
rriddle added reviewers: mehdi_amini, jpienaar.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako.
Herald added a reviewer: mravishankar.
Herald added a reviewer: antiagainst.
Herald added a project: LLVM.
rriddle added a child revision: D76203: [mlir] Add a hook to PatternRewriter to allow for patterns to notify why a match failed..

PatternState was a mechanism to pass state between the match and rewrite calls of a RewritePattern. With the rise of matchAndRewrite, this class is unused and unnecessary. This revision removes PatternState and simplifies PatternMatchResult to just be a LogicalResult. A future revision will replace all usages of PatternMatchResult/matchSuccess/matchFailure with LogicalResult equivalents.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76202

Files:
  mlir/include/mlir/IR/PatternMatch.h
  mlir/include/mlir/Transforms/DialectConversion.h
  mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
  mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp
  mlir/lib/IR/PatternMatch.cpp
  mlir/lib/Transforms/DialectConversion.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76202.250440.patch
Type: text/x-patch
Size: 9747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200315/da1223b4/attachment-0001.bin>


More information about the llvm-commits mailing list