[PATCH] D76178: [lit] Recursively apply substitutions

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 14 10:11:20 PDT 2020


dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

This looks really cool.  Can you add tests for this feature, somewhere inside `llvm/utils/lit/tests`?



================
Comment at: llvm/utils/lit/lit/TestRunner.py:1176
+
+    def fullyProcessLine(ln):
+        processed = processLine(ln)
----------------
I suggest `processLineRecursively` or `processLineToFixedPoint` instead of `fullyProcessLine`, since I don't think the word "fully" is clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76178/new/

https://reviews.llvm.org/D76178





More information about the llvm-commits mailing list