[PATCH] D76110: CMake: Turn LLVM_ENABLE_ZLIB into a tri-state option

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 14 07:29:11 PDT 2020


grimar added inline comments.


================
Comment at: llvm/CMakeLists.txt:351
 
-option(LLVM_ENABLE_ZLIB "Use zlib for compression/decompression if available." ON)
+set(LLVM_ENABLE_ZLIB "ON" CACHE STRING "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON")
 
----------------
I wonder if `REQUIRE` sounds better. 
(For me it was not clear what `FORCE_ON` means from its name).

But, it is not consistent with the existent `FORCE_ON` used for libxml2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76110/new/

https://reviews.llvm.org/D76110





More information about the llvm-commits mailing list