[PATCH] D76156: Initialize IsFast* values

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 14 04:15:16 PDT 2020


RKSimon added a comment.

In D76156#1922562 <https://reviews.llvm.org/D76156#1922562>, @bcain wrote:

> This change seemed inocent enough.  Were the `false` values here the right defaults?


Yes, we tend to check for IsFast=true after most successful allowsMemoryAccess calls so false is the better default. But really if a target allowsMemoryAccess implementation is going to return true it should always explicitly set the IsFast value as well.

> Could this regression really be due to this change?
> 
> http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/5090/steps/test-openmp/logs/FAIL%3A%20libomp%3A%3Abug_nested_proxy_task.c

The openmp buildbots are notoriously unreliable - my recommendation for those bots is always to wait for another build to see if the red just goes away.....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76156/new/

https://reviews.llvm.org/D76156





More information about the llvm-commits mailing list