[PATCH] D71847: [OpenMP][Part 1] Reusable OpenMP context/traits handling

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPContext.h:119
+
+  SmallSet<TraitProperty, 8> RequiredTraits;
+  SmallVector<TraitProperty, 8> ConstructTraits;
----------------
I'd suggest that you think about different data structures here. I noticed that this instantiation of SmallSet, which wraps std::set, takes ~20ms, and happens in every file that includes OMPContext.h.

Can you use a BitVector or std::bitset instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71847/new/

https://reviews.llvm.org/D71847