[PATCH] D76157: [SelectionDAGBuilder] Don't set MachinePointerInfo for gather when we find a uniform base

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 13:29:27 PDT 2020


craig.topper created this revision.
craig.topper added reviewers: efriedma, RKSimon, spatel.
Herald added a subscriber: hiraditya.

I believe we were previously calculating a pointer info with the scalar base and an offset of 0. But that's not really where the gather is pointing. The offset is a function of the indices of the GEP we looked through.

Also get rid of the constant memory stuff for gather because I'm not sure that was right either.

I'm also not sure the memory size for the gather/scatter is correct either since I think it using the vector VT, but we're really loading/storing multiple disjoint scalars.


https://reviews.llvm.org/D76157

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76157.250287.patch
Type: text/x-patch
Size: 4071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200313/50cbd656/attachment.bin>


More information about the llvm-commits mailing list