[PATCH] D76135: [MachineLICM] Don't treat cross copies as cheap

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 10:44:33 PDT 2020


dmgreen updated this revision to Diff 250256.
dmgreen added a comment.

Thanks for the suggestion.

I made it call shouldRewriteCopySrc, which allows the target to modify things if it wishes. The AMDGPU/idiv-licm.ll test changed ever so slightly. Let me know if I should change things around to instead call shareSameRegisterFile more directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76135/new/

https://reviews.llvm.org/D76135

Files:
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/test/CodeGen/AMDGPU/idiv-licm.ll
  llvm/test/CodeGen/AMDGPU/sdiv64.ll
  llvm/test/CodeGen/AMDGPU/sdwa-peephole.ll
  llvm/test/CodeGen/AMDGPU/srem64.ll
  llvm/test/CodeGen/AMDGPU/udiv64.ll
  llvm/test/CodeGen/AMDGPU/urem64.ll
  llvm/test/CodeGen/Thumb2/mve-floatregloops.ll
  llvm/test/CodeGen/Thumb2/mve-pred-threshold.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76135.250256.patch
Type: text/x-patch
Size: 80509 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200313/d193d99f/attachment-0001.bin>


More information about the llvm-commits mailing list