[PATCH] D76136: [MLIR] Add support for explicitly signed / unsigned integer constants

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 09:39:50 PDT 2020


rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.

Thanks for the patch! StandardOps is designed to use only signless integers, any deviation will require an RFC and justification as to why the change is desired. See https://mlir.llvm.org/docs/Rationale/#integer-signedness-semantics
Thanks again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76136/new/

https://reviews.llvm.org/D76136





More information about the llvm-commits mailing list